Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Enable Comparison between timestamp / dates #1689

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Dec 1, 2023

  • Enables comparisons between Timestamps of no / same / different timezones and units
  • Enables comparisons between dates and timestamps
  • Adds Date / Timestamps to expression fixtures
  • However we do not allow compare a TimeStamp with no tz with one that has one.

@github-actions github-actions bot added the enhancement New feature or request label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #1689 (2329aff) into main (17bc896) will decrease coverage by 0.22%.
Report is 1 commits behind head on main.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1689      +/-   ##
==========================================
- Coverage   85.10%   84.89%   -0.22%     
==========================================
  Files          55       55              
  Lines        5345     5349       +4     
==========================================
- Hits         4549     4541       -8     
- Misses        796      808      +12     
Files Coverage Δ
daft/datatype.py 91.75% <83.33%> (-0.24%) ⬇️

... and 6 files with indirect coverage changes

@samster25 samster25 requested a review from jaychia December 1, 2023 05:01
@samster25 samster25 merged commit 2d499c4 into main Dec 1, 2023
41 of 42 checks passed
@samster25 samster25 deleted the sammy/timestamp-cmp branch December 1, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant