Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Remove usage of credentials in workflows #1686

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Nov 30, 2023

This allows PRs from forks to be green

  • Tests which require credentials are now only run on main, on a separate job called integration-test-io-credentialed
  • The fixtures providing IOConfigs now conditionally set anonymous=True depending on whether the test is triggered with the --credentials option, which is a custom option added to pytest

@github-actions github-actions bot added the chore label Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #1686 (de005eb) into main (cb1fb22) will increase coverage by 0.06%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
+ Coverage   85.04%   85.10%   +0.06%     
==========================================
  Files          55       55              
  Lines        5341     5345       +4     
==========================================
+ Hits         4542     4549       +7     
+ Misses        799      796       -3     

see 1 file with indirect coverage changes

Copy link
Member

@samster25 samster25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jaychia jaychia merged commit 17bc896 into main Dec 1, 2023
42 checks passed
@jaychia jaychia deleted the jay/remove-creds-workflows branch December 1, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants