Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Improve error messages when calling aggregation methods on dataframe without input columns #1587

Merged
merged 5 commits into from
Nov 13, 2023

fix import order

5c787ae
Select commit
Loading
Failed to load commit list.
Merged

[CHORE] Improve error messages when calling aggregation methods on dataframe without input columns #1587

fix import order
5c787ae
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 13, 2023 in 1s

82.89% (-2.01%) compared to 96b73d6

View this Pull Request on Codecov

82.89% (-2.01%) compared to 96b73d6

Details

Codecov Report

Merging #1587 (5c787ae) into main (96b73d6) will decrease coverage by 2.01%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1587      +/-   ##
==========================================
- Coverage   84.90%   82.89%   -2.01%     
==========================================
  Files          54       54              
  Lines        5162     5222      +60     
==========================================
- Hits         4383     4329      -54     
- Misses        779      893     +114
Files Coverage Δ
daft/dataframe/dataframe.py 87.07% <100.00%> (-2.52%) ⬇️

... and 12 files with indirect coverage changes

View more details on Codecov