Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] update s3 connection defaults #1451

Merged
merged 1 commit into from
Oct 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/common/io-config/src/python.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ use crate::config;
/// endpoint_url: URL to the S3 endpoint, defaults to endpoints to AWS
/// key_id: AWS Access Key ID, defaults to auto-detection from the current environment
/// access_key: AWS Secret Access Key, defaults to auto-detection from the current environment
/// max_connections: Maximum number of connections to S3 at any time, defaults to 1024
/// max_connections: Maximum number of connections to S3 at any time, defaults to 64
/// session_token: AWS Session Token, required only if `key_id` and `access_key` are temporary credentials
/// retry_initial_backoff_ms: Initial backoff duration in milliseconds for an S3 retry, defaults to 1000ms
/// connect_timeout_ms: Timeout duration to wait to make a connection to S3 in milliseconds, defaults to 60 seconds
/// read_timeout_ms: Timeout duration to wait to read the first byte from S3 in milliseconds, defaults to 60 seconds
/// connect_timeout_ms: Timeout duration to wait to make a connection to S3 in milliseconds, defaults to 10 seconds
/// read_timeout_ms: Timeout duration to wait to read the first byte from S3 in milliseconds, defaults to 10 seconds
/// num_tries: Number of attempts to make a connection, defaults to 5
/// retry_mode: Retry Mode when a request fails, current supported values are `standard` and `adaptive`
/// retry_mode: Retry Mode when a request fails, current supported values are `standard` and `adaptive`, defaults to `adaptive`
/// anonymous: Whether or not to use "anonymous mode", which will access S3 without any credentials
/// verify_ssl: Whether or not to verify ssl certificates, which will access S3 without checking if the certs are valid, defaults to True
/// check_hostname_ssl: Whether or not to verify the hostname when verifying ssl certificates, this was the legacy behavior for openssl, defaults to True
Expand Down
8 changes: 4 additions & 4 deletions src/common/io-config/src/s3.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ impl Default for S3Config {
key_id: None,
session_token: None,
access_key: None,
max_connections: 1024,
max_connections: 64,
retry_initial_backoff_ms: 1000,
connect_timeout_ms: 60_000,
read_timeout_ms: 60_000,
connect_timeout_ms: 10_000,
read_timeout_ms: 10_000,
num_tries: 5,
retry_mode: Some("standard".to_string()),
retry_mode: Some("adaptive".to_string()),
anonymous: false,
verify_ssl: true,
check_hostname_ssl: true,
Expand Down
Loading