[CHORE] Complete removal of fsspec #1448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaychia
force-pushed
the
jay/remove-fsspec-user-facing-api
branch
2 times, most recently
from
7aae8b8 to
0ab356a
Compare
jaychia
force-pushed
the
jay/remove-fsspec-user-facing-api
branch
from
0ab356a to
9c7f431
Compare
jaychia
changed the title
|
Closing this branch until we decide to completely eliminate non-native reads |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all user-facing
fsspecAPIs.After this PR, we no longer need
fsspecas a dependency.fs=kwarg from:a.
daft.read_parquetb.
daft.read_jsonc.
daft.read_csvfskwarg is also removed in all downstream APIs.StorageConfigwhich used to help us pass along fsspec-parametrized IO configurations. Now we just use a nakedIOConfigobject.