Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix scheme bug in GCS anonymous mode #1443

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Sep 25, 2023

I think the "deadlocking" in #1432 is actually caused by Python's difflib being really slow on the diff of the bad result.

Also, because our io integration tests on that workflow isn't provided with GCP credentials, it is defaulting to the "anonymous" GCS client which is s3 based. We should fix that once we verify that this fix works.

Closes: #1432

@github-actions github-actions bot added the bug Something isn't working label Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #1443 (81f5b7c) into main (ecb596a) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 81f5b7c differs from pull request most recent head 6943118. Consider uploading reports for the commit 6943118 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1443      +/-   ##
==========================================
- Coverage   74.51%   74.51%   -0.01%     
==========================================
  Files          60       60              
  Lines        6035     6034       -1     
==========================================
- Hits         4497     4496       -1     
  Misses       1538     1538              

see 4 files with indirect coverage changes

@jaychia jaychia enabled auto-merge (squash) September 25, 2023 22:46
@jaychia jaychia merged commit a024123 into main Sep 25, 2023
22 checks passed
@jaychia jaychia deleted the jay/fix-scheme-anon-gcs branch September 25, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Nightly wheel integration IO tests deadlocking
1 participant