[BUG] Fix scheme bug in GCS anonymous mode #1443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the "deadlocking" in #1432 is actually caused by Python's difflib being really slow on the diff of the bad result.
Also, because our io integration tests on that workflow isn't provided with GCP credentials, it is defaulting to the "anonymous" GCS client which is s3 based. We should fix that once we verify that this fix works.
Closes: #1432