Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix gs listing to include 0 sized marker files #1412

Merged
merged 4 commits into from
Sep 23, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Sep 23, 2023

  • Fix gs listing to include 0 sized marker files (these files are created when manually creating folders in the UI)
  • Fixes also for multiple trailing delimiters
  • More test coverage for recursive cases

@jaychia jaychia enabled auto-merge (squash) September 23, 2023 00:21
@github-actions github-actions bot added the bug Something isn't working label Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #1412 (1bc66d5) into main (7d199d2) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1412      +/-   ##
==========================================
- Coverage   87.79%   87.78%   -0.02%     
==========================================
  Files          60       60              
  Lines        6032     6032              
==========================================
- Hits         5296     5295       -1     
- Misses        736      737       +1     

see 1 file with indirect coverage changes

@jaychia jaychia merged commit 1526233 into main Sep 23, 2023
27 checks passed
@jaychia jaychia deleted the jay/gcs-ls-marker-files branch September 23, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant