[FEAT] Add .str.split() API for splitting string columns.
#1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
==========================================
+ Coverage 74.61% 74.64% +0.03%
==========================================
Files 60 60
Lines 6034 6042 +8
==========================================
+ Hits 4502 4510 +8
Misses 1532 1532
|
clarkzinzow
commented
Sep 22, 2023
| @@ -129,7 +129,8 @@ impl FullNull for ListArray { | |||
| Self::new( | |||
| Field::new(name, dtype.clone()), | |||
| empty_flat_child, | |||
| OffsetsBuffer::try_from(repeat(0).take(length).collect::<Vec<_>>()).unwrap(), | |||
| OffsetsBuffer::try_from(repeat(0).take(length + 1).collect::<Vec<_>>()) | |||
There was a problem hiding this comment.
@jaychia FYI I made this fix as a driveby, where the offset buffer should be one element longer than the data array and validity mask.
There was a problem hiding this comment.
Hmm odd, this should have been caught be an assert in the constructor. Maybe we need to add one?
clarkzinzow
force-pushed
the
clark/expr-str-split
branch
from
4fc736d to
2a8d6aa
Compare
jaychia
approved these changes
Sep 26, 2023
| @@ -129,7 +129,8 @@ impl FullNull for ListArray { | |||
| Self::new( | |||
| Field::new(name, dtype.clone()), | |||
| empty_flat_child, | |||
| OffsetsBuffer::try_from(repeat(0).take(length).collect::<Vec<_>>()).unwrap(), | |||
| OffsetsBuffer::try_from(repeat(0).take(length + 1).collect::<Vec<_>>()) | |||
There was a problem hiding this comment.
Hmm odd, this should have been caught be an assert in the constructor. Maybe we need to add one?
clarkzinzow
force-pushed
the
clark/expr-str-split
branch
from
2a8d6aa to
b1dc2b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
Expression.str.split()API for splitting strings in string columns on a pattern.Closes #1388