Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Native listing of http URLs #1405

Merged
merged 10 commits into from
Sep 26, 2023
Merged

[FEAT] Native listing of http URLs #1405

merged 10 commits into from
Sep 26, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Sep 22, 2023

Adds capabilities for our HTTP source to perform file listing

Logic is roughly adapted from fsspec's HTTPFileSystem in order to maintain some parity with how it behaves.

Current differences in behavior:

  1. We don't support fsspec's simple_links=True option, which would search for any text starting with http(s):// and that aren't encased in a HTML <a href=...> tag.
  2. When pointed at a single file, fsspec returns an empty list but we detect whether the file is HTML and return a list with just the file itself if we see that it is not HTML.

Closes: #1440

@jaychia jaychia marked this pull request as draft September 22, 2023 02:51
@github-actions github-actions bot added the enhancement New feature or request label Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #1405 (62b11d3) into main (97845d3) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 62b11d3 differs from pull request most recent head c459e94. Consider uploading reports for the commit c459e94 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1405   +/-   ##
=======================================
  Coverage   74.61%   74.61%           
=======================================
  Files          60       60           
  Lines        6034     6034           
=======================================
  Hits         4502     4502           
  Misses       1532     1532           

@jaychia jaychia marked this pull request as ready for review September 22, 2023 20:13
@jaychia jaychia enabled auto-merge (squash) September 26, 2023 01:21
@jaychia jaychia merged commit 558b31e into main Sep 26, 2023
22 checks passed
@jaychia jaychia deleted the jay/http-ls branch September 26, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native filesystem globbing - HTTP
1 participant