[CHORE] Centralize pyo3 pickling around __reduce__ + bincode macro.
#1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1394 +/- ##
==========================================
- Coverage 87.81% 87.79% -0.02%
==========================================
Files 60 60
Lines 6041 6032 -9
==========================================
- Hits 5305 5296 -9
Misses 736 736
|
samster25
reviewed
Sep 21, 2023
| @@ -11,7 +11,7 @@ use common_error::{DaftError, DaftResult}; | |||
| /// Supported image formats for Daft's I/O layer. | |||
| #[allow(clippy::upper_case_acronyms)] | |||
| #[derive(Clone, Copy, Debug, PartialEq, Eq, Serialize, Deserialize, Hash)] | |||
| #[cfg_attr(feature = "python", pyclass)] | |||
| #[cfg_attr(feature = "python", pyclass(module = "daft.daft"))] | |||
There was a problem hiding this comment.
could we make an attr that is daftpyclass=pyclass(module = "daft.daft") and use that everywhere?
| &self, | ||
| py: Python, | ||
| cast_tensor_type_for_ray: Option<bool>, | ||
| ) -> PyResult<PyObject> { |
There was a problem hiding this comment.
is this a bad diff? what's different
There was a problem hiding this comment.
Ah, this is a driveby! This was me noticing that we were redundantly capturing the GIL with Python::with_gil(|py| ...) when pyo3 methods already have the GIL, and the py: Python marker token can be transparently injected into the method by specifying it as an argument.
| } | ||
|
|
||
| impl_bincode_py_state_serialization!(PyField); |
There was a problem hiding this comment.
this might be a good macro to implement as a derive so we can #[derive(PySerDe)]
clarkzinzow
force-pushed
the
clark/pyo3-pickling
branch
from
e01594f to
fec0c70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports all pyo3-exposed classes that need to be picklable to use a
__reduce__+ bincode macro, which removes the need for a dummy/inefficient no-arg constructor.