Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Native Rust listing of GCS #1392

Merged
merged 13 commits into from
Sep 22, 2023
Merged

[FEAT] Native Rust listing of GCS #1392

merged 13 commits into from
Sep 22, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Sep 20, 2023 •
edited
Loading

Implements ls functionality for GCS

@github-actions github-actions bot added the enhancement New feature or request label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #1392 (38559a8) into main (2bb2aa4) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1392   +/-   ##
=======================================
  Coverage   87.80%   87.80%           
=======================================
  Files          60       60           
  Lines        6041     6041           
=======================================
  Hits         5304     5304           
  Misses        737      737

@jaychia jaychia requested a review from samster25 September 20, 2023 22:24
samster25
samster25 reviewed Sep 20, 2023
View reviewed changes
src/daft-io/src/google_cloud.rs Outdated Show resolved Hide resolved
src/daft-io/src/google_cloud.rs Outdated Show resolved Hide resolved
tests/integration/io/test_list_files_gcs.py Show resolved Hide resolved
@jaychia jaychia enabled auto-merge (squash) September 21, 2023 19:28
@jaychia jaychia disabled auto-merge September 21, 2023 19:31
@jaychia jaychia enabled auto-merge (squash) September 21, 2023 19:40
@jaychia jaychia merged commit 8c20f39 into main Sep 22, 2023
27 checks passed
@jaychia jaychia deleted the jay/gs-ls branch September 22, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samster25 samster25 samster25 left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaychia @samster25