Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add support for windows in daft #1386

Merged
merged 37 commits into from
Sep 25, 2023
Merged

[FEAT] Add support for windows in daft #1386

merged 37 commits into from
Sep 25, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Sep 19, 2023

  • Implements fixes for daft to be able to build for windows
  • implements protocol checking in filesystem.py for windows style paths
  • implements protocol checking in native local objectio for windows style paths.
  • fix unit tests to use os libraries to construct path
  • rewrite file io unit tests to not use a open file descriptor which breaks on windows
  • disable AVX for x86 builds for mac and windows
  • implement unit test, rust tests and import tests CI for windows
  • implements windows wheel building for publish pipeline
  • disables query plan toggle for CI
  • fix REPR style unit tests for \r

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1386 (2be8b07) into main (e6252f9) will decrease coverage by 13.27%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1386       +/-   ##
===========================================
- Coverage   87.78%   74.51%   -13.27%     
===========================================
  Files          60       60               
  Lines        6032     6035        +3     
===========================================
- Hits         5295     4497      -798     
- Misses        737     1538      +801     
Files Changed Coverage Δ
daft/filesystem.py 86.74% <100.00%> (+0.24%) ⬆️

... and 14 files with indirect coverage changes

@samster25 samster25 changed the title try build windows wheel [FEAT] Release Windows Wheels Sep 19, 2023
@github-actions github-actions bot added the enhancement New feature or request label Sep 19, 2023
This was linked to issues Sep 25, 2023
@samster25 samster25 changed the title [FEAT] Release Windows Wheels [FEAT] Add support for windows in daft Sep 25, 2023
@samster25 samster25 merged commit d7d1ae0 into main Sep 25, 2023
29 of 30 checks passed
@samster25 samster25 deleted the sammy/windows-wheel branch September 25, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows10 install daft failed Build windows wheels
1 participant