Skip to content

Commit

Permalink
[CHORE] Edit 'make-hooks' command to install pre-commit script (#1602)
Browse files Browse the repository at this point in the history
I noticed after following the [contributing
guide](https://github.com/Eventual-Inc/Daft/blob/main/CONTRIBUTING.md#development-environment)
and running 'make hooks', the pre-commit hooks did not run when I commit
changes.

Not sure if this was intended, but looking at
https://pre-commit.com/#pre-commit-install-hooks:
```
pre-commit install-hooks does not install the pre-commit script. 
To install the script along with the hook environments in one command, use pre-commit install --install-hooks.
```

See also: pre-commit/pre-commit.com#255
  • Loading branch information
colin-ho authored Nov 13, 2023
1 parent b4467ad commit fbbeff3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ endif

.PHONY: hooks
hooks: venv
source $(VENV_BIN)/activate && pre-commit install-hooks
source $(VENV_BIN)/activate && pre-commit install --install-hooks

.PHONY: build
build: venv ## Compile and install Daft for development
Expand Down

0 comments on commit fbbeff3

Please sign in to comment.