Skip to content

Commit

Permalink
[CHORE] drop s3 compat mode for gcs for anonymous mode (#1682)
Browse files Browse the repository at this point in the history
* `google-cloud-storage` crate now supports anonymous mode from this
[issue](yoshidan/google-cloud-rust#213) thanks
to this [PR](yoshidan/google-cloud-rust#217)
* This lets us drop S3 Compatibility mode for GCS
  • Loading branch information
samster25 authored Dec 1, 2023
1 parent b679661 commit f0ddb8c
Show file tree
Hide file tree
Showing 3 changed files with 174 additions and 259 deletions.
147 changes: 45 additions & 102 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion src/daft-io/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ common-io-config = {path = "../common/io-config", default-features = false}
daft-core = {path = "../daft-core", default-features = false}
futures = {workspace = true}
globset = "0.4"
google-cloud-storage = {version = "0.14.0", default-features = false, features = ["default-tls", "auth"]}
hyper = "0.14.27"
hyper-tls = "0.5.0"
itertools = {workspace = true}
Expand All @@ -35,6 +34,15 @@ tokio = {workspace = true}
tokio-stream = {workspace = true}
url = {workspace = true}

[dependencies.google-cloud-storage]
default-features = false
features = ["default-tls", "auth"]
# branch = "main"
git = "https://github.com/yoshidan/google-cloud-rust"
package = "google-cloud-storage"
rev = "65251957f6aed2eb8adb62b9a9a1b9996150d265"
version = "0.15.0"

[dependencies.reqwest]
default-features = false
features = ["stream", "native-tls"]
Expand Down
Loading

0 comments on commit f0ddb8c

Please sign in to comment.