improvements / comments

Eventual-Inc · Oct 4, 2024 · e0ec7e0 · e0ec7e0
1 parent 3b5b397
commit e0ec7e0
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/src/daft-core/src/array/mod.rs b/src/daft-core/src/array/mod.rs
@@ -53,11 +53,10 @@ impl<T> DataArray<T> {
         );
 
         if let Ok(expected_arrow_physical_type) = physical_field.dtype.to_arrow()
-        // For instance Int32 -> Int 32
         {
             let arrow_data_type = arrow_array.data_type(); // logical type
 
-            if !expected_arrow_physical_type.eq(arrow_data_type) {
+            if &expected_arrow_physical_type != arrow_data_type {
                 panic!(
                     "Mismatch between expected and actual Arrow types for DataArray.\n\
                 Field name: {}\n\

diff --git a/src/lib.rs b/src/lib.rs
@@ -96,7 +96,6 @@ pub mod pylib {
     #[pymodule]
     fn daft(py: Python, m: &Bound<PyModule>) -> PyResult<()> {
         refresh_logger(py)?;
-
         init_tracing(crate::should_enable_chrome_trace());
 
         common_daft_config::register_modules(m)?;

diff --git a/tests/expressions/test_expressions.py b/tests/expressions/test_expressions.py
@@ -516,7 +516,7 @@ def test_list_value_counts():
         {"list_col": [["a", "b", "a", "c"], ["b", "b", "c"], ["a", "a", "a"], [], ["d", None, "d"]]}
     )
 
-    # # Apply list_value_counts operation
+    # Apply list_value_counts operation
     result = mp.eval_expression_list([col("list_col").list.value_counts().alias("value_counts")])
     value_counts = result.to_pydict()["value_counts"]