Fix deserializing ints as strings.

Eventual-Inc · Dec 6, 2023 · ce4ac30 · ce4ac30
1 parent 4a2c336
commit ce4ac30
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/daft-json/src/decoding.rs b/src/daft-json/src/decoding.rs
@@ -230,8 +230,11 @@ fn deserialize_utf8_into<'a, O: Offset, A: Borrow<Value<'a>>>(
                 Number::Integer(number, exponent) | Number::Float(number, exponent) => {
                     scratch.clear();
                     scratch.extend_from_slice(number);
-                    scratch.push(b'e');
-                    scratch.extend_from_slice(exponent);
+                    if !exponent.is_empty() {
+                        scratch.push(b'e');
+                        scratch.extend_from_slice(exponent);
+                    }
+                    target.push(simdutf8::basic::from_utf8(scratch.as_slice()).ok());
                 }
             },
             Value::Bool(v) => target.push(Some(if *v { "true" } else { "false" })),

diff --git a/src/daft-json/src/read.rs b/src/daft-json/src/read.rs
@@ -127,11 +127,6 @@ pub fn read_json_bulk(
             .await
     })?;
     tables.into_iter().collect::<DaftResult<Vec<_>>>()
-
-    // Sort the task results by task index, yielding tables whose order matches the input URI order.
-    // let mut collected = tables.into_iter().collect::<DaftResult<Vec<_>>>()?;
-    // collected.sort_by_key(|(idx, _)| *idx);
-    // Ok(collected.into_iter().map(|(_, v)| v).collect())
 }
 
 async fn read_json_single_into_table(