Skip to content

Commit

Permalink
improve comment
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewgazelka committed Oct 4, 2024
1 parent c86cedb commit cae76fd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
7 changes: 6 additions & 1 deletion src/daft-core/src/array/ops/list.rs
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,12 @@ impl ListArray {
}
}

// indexmap so ordered
// IndexMap maintains insertion order, so we iterate over its values
// in the same order that elements were added. This ensures that
// the count_array values correspond to the same order in which
// the include_mask was set earlier in the loop. Each 'true' in
// include_mask represents a unique key, and its corresponding
// count is now added to count_array in the same sequence.
for v in map.values() {
count_array.push(*v);
}
Expand Down
1 change: 0 additions & 1 deletion src/daft-schema/src/dtype.rs
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,6 @@ impl DataType {
arrow2::datatypes::Field::new("value", value.to_arrow()?, true),
]);

// entries
let struct_field =
arrow2::datatypes::Field::new("entries", struct_type.clone(), true);

Expand Down

0 comments on commit cae76fd

Please sign in to comment.