Skip to content

Commit

Permalink
Cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
desmondcheongzx committed Dec 11, 2024
1 parent ba6eee2 commit c77c3d1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ impl GreedyJoinOrderer {
let right_neighbors = join_graph.adj_list.0.remove(&right).unwrap();
let mut new_join_edges = HashMap::new();

// Helper function that takes in neighbors to the left and right nodes, the combines edges that point
// Helper function that takes in neighbors to the left and right nodes, then combines edges that point
// back to the left and/or right nodes into edges that point to the new join node.
let mut update_neighbors =
|neighbors: HashMap<LogicalPlanRef, Vec<JoinCondition>>| {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ impl std::fmt::Display for JoinAdjList {
for (node, neighbors) in &self.0 {
writeln!(f, "Node {}:", node.name())?;
for (neighbor, join_conds) in neighbors {
writeln!(f, " -> {} with conditions:", neighbor.name())?;
writeln!(f, " -> {} with conditions:", neighbor.name())?;
for (i, cond) in join_conds.iter().enumerate() {
writeln!(f, " {}: {} = {}", i, cond.left_on, cond.right_on)?;

Check warning on line 81 in src/daft-logical-plan/src/optimization/rules/reorder_joins/join_graph.rs

View check run for this annotation

Codecov / codecov/patch

src/daft-logical-plan/src/optimization/rules/reorder_joins/join_graph.rs#L75-L81

Added lines #L75 - L81 were not covered by tests
}
Expand Down

0 comments on commit c77c3d1

Please sign in to comment.