Skip to content

Commit

Permalink
Add command to convert all semicolons to underscores
Browse files Browse the repository at this point in the history
  • Loading branch information
Raunak Bhagat committed Nov 20, 2024
1 parent fc4f378 commit b8d6251
Showing 1 changed file with 15 additions and 14 deletions.
29 changes: 15 additions & 14 deletions .github/workflows/run-tpch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
rm -rf daft
uv pip install ray[default] boto3 https://github-actions-artifacts-bucket.s3.us-west-2.amazonaws.com/builds/${{ github.sha }}/${{ inputs.wheel }}
# Boot up ray cluster
# Boot up ray cluster and submit tpch benchmarking job
ray up .github/assets/ray.yaml -y
HEAD_NODE_IP=$(ray get-head-ip .github/assets/ray.yaml | tail -n 1)
ssh -o StrictHostKeyChecking=no -fN -L 8265:localhost:8265 -i ~/.ssh/ci-github-actions-ray-cluster-key.pem ubuntu@$HEAD_NODE_IP
Expand All @@ -105,22 +105,23 @@ jobs:
--no_pymodules
fi
# Download all logs
# (We also need to convert all files containing ':' to '_'.
# GHA `actions/upload-artifact@v4` does *not* allow semicolons!)
ray rsync-down .github/assets/ray.yaml /tmp/ray ray-logs
find ray-logs/ray/session_*/logs/daft -depth -name '*:*' -exec bash -c '
for filepath; do
dir=$(dirname "$filepath")
base=$(basename "$filepath")
new_base=${base//:/_}
mv "$filepath" "$dir/$new_base"
done
' _ {} +
# find /path/to/directory -depth -name '*:*' -exec bash -c '
# for filepath; do
# dir=$(dirname "$filepath")
# base=$(basename "$filepath")
# new_base=${base//:/_}
# mv "$filepath" "$dir/$new_base"
# done
# ' _ {} +

- uses: lhotari/action-upterm@v1

- run: |
source .venv/bin/activate
# Tear down ray cluster
ray down .github/assets/ray.yaml -y
# Convert csv to markdown and print to GHA Summary Page
python .github/scripts/csv_to_md.py output.csv output.md
echo "# Results" >> $GITHUB_STEP_SUMMARY
cat output.md >> $GITHUB_STEP_SUMMARY
Expand Down

0 comments on commit b8d6251

Please sign in to comment.