remove a bunch of tracing

Eventual-Inc · Sep 27, 2024 · afd282c · afd282c
1 parent 011b0e2
commit afd282c
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 6 deletions.
diff --git a/src/arrow2/src/array/map/mod.rs b/src/arrow2/src/array/map/mod.rs
@@ -203,7 +203,6 @@ impl MapArray {
 impl Array for MapArray {
     impl_common_array!();
 
-    #[tracing::instrument(level = "trace", name = "Array::convert_logical_type", skip_all)]
     fn convert_logical_type(&self, target: DataType) -> Box<dyn Array> {
         tracing::trace!("converting logical type to\n{target:#?}");
         let outer_is_map = matches!(target, DataType::Map { .. });
@@ -236,8 +235,6 @@ impl Array for MapArray {
         let offsets = self.offsets().clone();
         let offsets = offsets.map(|offset| offset as i64);
 
-        let debug = format!("{:#?}", field.data_type());
-        let target_debug = format!("{:#?}", target);
         let list = ListArray::new(target, offsets, field, self.validity.clone());
 
         Box::new(list)

diff --git a/src/arrow2/src/array/mod.rs b/src/arrow2/src/array/mod.rs
@@ -188,7 +188,6 @@ pub trait Array: Send + Sync + dyn_clone::DynClone + 'static {
     /// ```
     /// # Panics
     /// Panics iff the `data_type`'s [`PhysicalType`] is not equal to array's `PhysicalType`.
-    #[tracing::instrument(level = "trace", name = "Array::convert_logical_type", skip_all)]
     fn convert_logical_type(&self, data_type: DataType) -> Box<dyn Array> {
         let mut new = self.to_boxed();
         new.change_type(data_type);

diff --git a/src/daft-core/src/series/from.rs b/src/daft-core/src/series/from.rs
@@ -3,7 +3,6 @@ use std::sync::Arc;
 use arrow2::datatypes::ArrowDataType;
 use common_error::{DaftError, DaftResult};
 use daft_schema::{dtype::DaftDataType, field::DaftField};
-use tracing::instrument;
 
 use super::Series;
 use crate::{

diff --git a/src/daft-schema/src/dtype.rs b/src/daft-schema/src/dtype.rs
@@ -198,7 +198,6 @@ impl DataType {
         Self::FixedSizeList(Box::new(datatype), size)
     }
 
-    #[tracing::instrument(level = "trace", name = "DataType::to_arrow")]
     pub fn to_arrow(&self) -> DaftResult<ArrowType> {
         match self {
             Self::Null => Ok(ArrowType::Null),