iceberg fix

Eventual-Inc · Oct 3, 2024 · 823e889 · 823e889
1 parent 4d5af1a
commit 823e889
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 11 deletions.
diff --git a/src/daft-plan/src/builder.rs b/src/daft-plan/src/builder.rs
@@ -479,9 +479,7 @@ impl LogicalPlanBuilder {
         table_name: String,
         table_location: String,
         partition_spec: PyObject,
-        partition_cols: Vec<ExprRef>,
         iceberg_schema: PyObject,
-        daft_iceberg_schema: SchemaRef,
         iceberg_properties: PyObject,
         io_config: Option<IOConfig>,
         catalog_columns: Vec<String>,
@@ -491,9 +489,7 @@ impl LogicalPlanBuilder {
                 table_name,
                 table_location,
                 partition_spec,
-                partition_cols,
                 iceberg_schema,
-                daft_iceberg_schema,
                 iceberg_properties,
                 io_config,
             }),
@@ -898,9 +894,7 @@ impl PyLogicalPlanBuilder {
         table_name: String,
         table_location: String,
         partition_spec: PyObject,
-        partition_cols: Vec<PyExpr>,
         iceberg_schema: PyObject,
-        daft_iceberg_schema: PySchema,
         iceberg_properties: PyObject,
         catalog_columns: Vec<String>,
         io_config: Option<common_io_config::python::IOConfig>,
@@ -911,9 +905,7 @@ impl PyLogicalPlanBuilder {
                 table_name,
                 table_location,
                 partition_spec,
-                pyexprs_to_exprs(partition_cols),
                 iceberg_schema,
-                daft_iceberg_schema.into(),
                 iceberg_properties,
                 io_config.map(|cfg| cfg.config),
                 catalog_columns,

diff --git a/src/daft-plan/src/sink_info.rs b/src/daft-plan/src/sink_info.rs
@@ -4,7 +4,6 @@ use common_file_formats::FileFormat;
 use common_io_config::IOConfig;
 #[cfg(feature = "python")]
 use common_py_serde::{deserialize_py_object, serialize_py_object};
-use daft_core::prelude::SchemaRef;
 use daft_dsl::ExprRef;
 use derivative::Derivative;
 use itertools::Itertools;
@@ -57,15 +56,13 @@ pub struct IcebergCatalogInfo {
     #[derivative(PartialEq = "ignore")]
     #[derivative(Hash = "ignore")]
     pub partition_spec: PyObject,
-    pub partition_cols: Vec<ExprRef>,
     #[serde(
         serialize_with = "serialize_py_object",
         deserialize_with = "deserialize_py_object"
     )]
     #[derivative(PartialEq = "ignore")]
     #[derivative(Hash = "ignore")]
     pub iceberg_schema: PyObject,
-    pub daft_iceberg_schema: SchemaRef,
     #[serde(
         serialize_with = "serialize_py_object",
         deserialize_with = "deserialize_py_object"