Remove ScanOperator commented code.

Eventual-Inc · Feb 24, 2024 · 7fb7e37 · 7fb7e37
1 parent 4729e90
commit 7fb7e37
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 31 deletions.
diff --git a/src/daft-scan/src/anonymous.rs b/src/daft-scan/src/anonymous.rs
@@ -50,19 +50,6 @@ impl ScanOperator for AnonymousScanOperator {
         false
     }
 
-    // fn is_eq(&self, other: &dyn ScanOperator) -> Option<bool> {
-    //     Some(
-    //         (other as &dyn Any)
-    //             .downcast_ref::<Self>()
-    //             .map(|o| self == o)
-    //             .unwrap_or(false),
-    //     )
-    // }
-
-    // fn hash_op(&self, state: &mut dyn Hasher) -> Option<()> {
-    //     Some(self.hash(state))
-    // }
-
     fn multiline_display(&self) -> Vec<String> {
         let mut lines = vec![
             "AnonymousScanOperator".to_string(),

diff --git a/src/daft-scan/src/glob.rs b/src/daft-scan/src/glob.rs
@@ -236,15 +236,6 @@ impl ScanOperator for GlobScanOperator {
         false
     }
 
-    // fn is_eq(&self, other: &dyn ScanOperator) -> Option<bool> {
-    //     Some(
-    //         (other as &dyn Any)
-    //             .downcast_ref::<Self>()
-    //             .map(|o| self == o)
-    //             .unwrap_or(false),
-    //     )
-    // }
-
     fn multiline_display(&self) -> Vec<String> {
         let mut lines = vec![
             "GlobScanOperator".to_string(),

diff --git a/src/daft-scan/src/lib.rs b/src/daft-scan/src/lib.rs
@@ -546,8 +546,6 @@ pub trait ScanOperator: Send + Sync + Debug + Any {
     fn can_absorb_select(&self) -> bool;
     fn can_absorb_limit(&self) -> bool;
     fn multiline_display(&self) -> Vec<String>;
-    // fn is_eq(&self, _: &dyn ScanOperator) -> Option<bool>;
-    // fn hash_op(&self, state: &mut dyn Hasher) -> Option<()>;
     fn to_scan_tasks(
         &self,
         pushdowns: Pushdowns,
@@ -581,9 +579,6 @@ impl Hash for ScanOperatorRef {
 impl PartialEq<ScanOperatorRef> for ScanOperatorRef {
     fn eq(&self, other: &ScanOperatorRef) -> bool {
         Arc::ptr_eq(&self.0, &other.0)
-        // self.0
-        //     .is_eq(other.0.as_ref())
-        //     .unwrap_or_else(|| Arc::ptr_eq(&self.0, &other.0))
     }
 }
 

diff --git a/src/daft-scan/src/python.rs b/src/daft-scan/src/python.rs
@@ -190,10 +190,6 @@ pub mod pylib {
             self.can_absorb_select
         }
 
-        // fn is_eq(&self, _: &dyn ScanOperator) -> Option<bool> {
-        //     None
-        // }
-
         fn multiline_display(&self) -> Vec<String> {
             let lines = vec![format!("PythonScanOperator: {}", self.display_name)];
             lines