Skip to content

Commit

Permalink
Add cluster-profile and env-vars to tpcds wrapper
Browse files Browse the repository at this point in the history
  • Loading branch information
raunakab committed Dec 19, 2024
1 parent a268d8c commit 7a8ae8d
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions tools/tpcds.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ def run(
commit_hash: str,
questions: str,
scale_factor: int,
cluster_profile: str,
env_vars: str,
):
user_wants_to_run_tpcds_benchmarking = inquirer.confirm(
message=f"Going to run the 'run-cluster' workflow on the branch '{branch_name}' (commit-hash: {commit_hash}); proceed?"
Expand All @@ -144,9 +146,11 @@ def run(
workflow=workflow,
branch_name=branch_name,
inputs={
"cluster_profile": cluster_profile,
"working_dir": "benchmarking/tpcds",
"entrypoint_script": "ray_entrypoint.py",
"entrypoint_args": entrypoint_args,
"env_vars": env_vars,
},
)

Expand All @@ -155,13 +159,17 @@ def main(
branch_name: Optional[str],
questions: str,
scale_factor: int,
cluster_profile: str,
env_vars: str,
):
branch_name, commit_hash = get_name_and_commit_hash(branch_name)
run(
branch_name=branch_name,
commit_hash=commit_hash,
questions=questions,
scale_factor=scale_factor,
cluster_profile=cluster_profile,
env_vars=env_vars,
)


Expand All @@ -172,6 +180,13 @@ def main(
"--questions", type=str, required=False, default="*", help="A comma separated list of questions to run"
)
parser.add_argument("--scale-factor", type=int, required=False, default=2, help="The scale factor to run on")
parser.add_argument("--cluster-profile", type=str, required=False, help="The ray cluster configuration to run on")
parser.add_argument(
"--env-vars",
type=str,
required=False,
help="A comma separated list of environment variables to pass to ray job",
)
parser.add_argument("--verbose", action="store_true", help="Verbose debugging")
args = parser.parse_args()

Expand All @@ -182,4 +197,6 @@ def main(
branch_name=args.ref,
questions=args.questions,
scale_factor=args.scale_factor,
cluster_profile=args.cluster_profile,
env_vars=args.env_vars,
)

0 comments on commit 7a8ae8d

Please sign in to comment.