Skip to content

Commit

Permalink
nit naming
Browse files Browse the repository at this point in the history
  • Loading branch information
Jay Chia committed Dec 12, 2024
1 parent a8cb301 commit 55b471b
Showing 1 changed file with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ impl<T: Fetchable> State<T> {
match &self {
Self::ConstructingWindow(_) => {
let next_fetchable = inputs.next();
self.handle_next_fetchable(next_fetchable, max_num_fetchables_per_window)
self.handle_constructing_window(next_fetchable, max_num_fetchables_per_window)
}
Self::WindowFinalized(_) => self.handle_window_finalized(),
Self::WindowFetched(_) => self.handle_window_fetched(),
Expand All @@ -133,15 +133,17 @@ impl<T: Fetchable> State<T> {
matches!(self, Self::Exhausted)
}

fn handle_next_fetchable(
fn handle_constructing_window(
mut self,
next_fetchable: Option<DaftResult<T>>,
max_num_fetchables_per_window: &usize,
) -> (Self, Option<DaftResult<T::Fetched>>) {
let accumulating_window = if let Self::ConstructingWindow(accumulating_window) = &mut self {
accumulating_window
} else {
unreachable!("handle_next_fetchable must be called from the ConstructingWindow state")
unreachable!(
"handle_constructing_window must be called from the ConstructingWindow state"
)

Check warning on line 146 in src/daft-scan/src/scan_task_iters/retrieve_parquet_metadata.rs

View check run for this annotation

Codecov / codecov/patch

src/daft-scan/src/scan_task_iters/retrieve_parquet_metadata.rs#L144-L146

Added lines #L144 - L146 were not covered by tests
};

if let Some(fetchable) = next_fetchable {
Expand Down

0 comments on commit 55b471b

Please sign in to comment.