lint fixes

Eventual-Inc · Sep 26, 2024 · 35a62b0 · 35a62b0
1 parent ca5e1c7
commit 35a62b0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/src/daft-core/src/series/ops/arithmetic.rs b/src/daft-core/src/series/ops/arithmetic.rs
@@ -1,7 +1,4 @@
-use std::{
-    ops::{Add, Div, Mul, Rem, Sub},
-    time::Duration,
-};
+use std::ops::{Add, Div, Mul, Rem, Sub};
 
 use common_error::DaftResult;
 use daft_schema::dtype::DataType;
@@ -86,26 +83,26 @@ impl Sub for &Series {
                     (DataType::Date, DataType::Duration(tu2)) => {
                         let days = rhs.duration()?.cast_to_days()?;
                         let physical_result = self.date()?.physical.sub(&days)?;
-                        physical_result.cast(&output_type)
+                        physical_result.cast(output_type)
                     }
                     (DataType::Date, DataType::Date) => {
                         let physical_result = self.date()?.physical.sub(&rhs.date()?.physical)?;
-                        physical_result.cast(&output_type)
+                        physical_result.cast(output_type)
                     }
                     (DataType::Duration(tu1), DataType::Duration(tu2)) => {
                         let physical_result =
                             lhs.duration()?.physical.sub(&rhs.duration()?.physical)?;
-                        physical_result.cast(&output_type)
+                        physical_result.cast(output_type)
                     }
                     (DataType::Timestamp(..), DataType::Duration(..)) => {
                         let physical_result =
                             self.timestamp()?.physical.sub(&rhs.duration()?.physical)?;
-                        physical_result.cast(&output_type)
+                        physical_result.cast(output_type)
                     }
                     (DataType::Timestamp(..), DataType::Timestamp(..)) => {
                         let physical_result =
                             self.timestamp()?.physical.sub(&rhs.timestamp()?.physical)?;
-                        physical_result.cast(&output_type)
+                        physical_result.cast(output_type)
                     }
                     _ => binary_op_unimplemented!(self, "-", rhs, output_type),
                 }

diff --git a/src/daft-core/src/series/ops/logical.rs b/src/daft-core/src/series/ops/logical.rs
@@ -21,10 +21,10 @@ macro_rules! binary_op_not_implemented {
     }};
 }
 
-impl DaftLogical<&Series> for Series {
-    type Output = DaftResult<Series>;
+impl DaftLogical<&Self> for Series {
+    type Output = DaftResult<Self>;
 
-    fn and(&self, rhs: &Series) -> Self::Output {
+    fn and(&self, rhs: &Self) -> Self::Output {
         let lhs = self;
         let output_type = InferDataType::from(lhs.data_type())
             .logical_op(&InferDataType::from(rhs.data_type()))?;
@@ -55,7 +55,7 @@ impl DaftLogical<&Series> for Series {
         }
     }
 
-    fn or(&self, rhs: &Series) -> Self::Output {
+    fn or(&self, rhs: &Self) -> Self::Output {
         let lhs = self;
         let output_type = InferDataType::from(self.data_type())
             .logical_op(&InferDataType::from(rhs.data_type()))?;
@@ -85,7 +85,7 @@ impl DaftLogical<&Series> for Series {
         }
     }
 
-    fn xor(&self, rhs: &Series) -> Self::Output {
+    fn xor(&self, rhs: &Self) -> Self::Output {
         let lhs = self;
         let output_type = InferDataType::from(self.data_type())
             .logical_op(&InferDataType::from(rhs.data_type()))?;