Skip to content

Commit

Permalink
try disabling rule
Browse files Browse the repository at this point in the history
  • Loading branch information
universalmind303 committed Nov 21, 2024
1 parent 5d7853e commit 1edcb7b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
11 changes: 6 additions & 5 deletions src/daft-logical-plan/src/optimization/optimizer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use super::{
logical_plan_tracker::LogicalPlanTracker,
rules::{
DropRepartition, EliminateCrossJoin, LiftProjectFromAgg, OptimizerRule, PushDownFilter,
PushDownLimit, PushDownProjection, SimplifyExpressionsRule, SplitActorPoolProjects,
PushDownLimit, PushDownProjection, SplitActorPoolProjects,
},
};
use crate::LogicalPlan;
Expand Down Expand Up @@ -94,10 +94,11 @@ impl Optimizer {
let mut rule_batches = Vec::new();

// we want to simplify expressions first to make the rest of the rules easier
rule_batches.push(RuleBatch::new(
vec![Box::new(SimplifyExpressionsRule::new())],
RuleExecutionStrategy::FixedPoint(Some(3)),
));
// dbg
// rule_batches.push(RuleBatch::new(
// vec![Box::new(SimplifyExpressionsRule::new())],
// RuleExecutionStrategy::FixedPoint(Some(3)),
// ));

// --- Split ActorPoolProjection nodes from Project nodes ---
// This is feature-flagged behind DAFT_ENABLE_ACTOR_POOL_PROJECTIONS=1
Expand Down
1 change: 1 addition & 0 deletions src/daft-logical-plan/src/optimization/rules/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@ pub use push_down_filter::PushDownFilter;
pub use push_down_limit::PushDownLimit;
pub use push_down_projection::PushDownProjection;
pub use rule::OptimizerRule;
#[allow(unused_imports)]
pub use simplify_expressions::SimplifyExpressionsRule;
pub use split_actor_pool_projects::SplitActorPoolProjects;

0 comments on commit 1edcb7b

Please sign in to comment.