windows handling for unit tests

Eventual-Inc · Sep 24, 2023 · 0c4cb66 · 0c4cb66
1 parent 07e9c99
commit 0c4cb66
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml
@@ -56,10 +56,18 @@ jobs:
         echo "$GITHUB_WORKSPACE/venv/bin" >> $GITHUB_PATH
 
     - name: Install dependencies
+      if: ${{ (matrix.os != 'windows') }}
       run: |
         pip install --upgrade pip
         pip install -r requirements-dev.txt
 
+    - name: Install dependencies (Windows)
+      if: ${{ (matrix.os == 'windows') }}
+      run: |
+        .\venv\Scripts\activate
+        pip install --upgrade pip
+        pip install -r requirements-dev.txt
+
     - name: Override pyarrow
       if: ${{ matrix.pyarrow-version }}
       run: pip install pyarrow==${{ matrix.pyarrow-version }}
@@ -83,16 +91,16 @@ jobs:
     - name: Build library and Test with pytest (windows)
       if: ${{ (matrix.os == 'windows') }}
       run: |
-        venv/bin/activate
+        .\venv\Scripts\activate
         # source <(cargo llvm-cov show-env --export-prefix)
         # export CARGO_TARGET_DIR=$CARGO_LLVM_COV_TARGET_DIR
         # export CARGO_INCREMENTAL=1
         # cargo llvm-cov clean --workspace
         maturin develop
-        mkdir -p report-output && pytest --cov=daft --ignore tests/integration --durations=50
+        mkdir -p report-output && pytest --cov=daft --ignore tests\integration --durations=50
         coverage combine -a --data-file='.coverage' || true
-        coverage xml -o ./report-output/coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.daft-runner }}-${{ matrix.pyarrow-version }}-${{ matrix.new-query-planner }}.xml
-        # cargo llvm-cov --no-run --lcov --output-path report-output/rust-coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.daft-runner }}-${{ matrix.pyarrow-version }}-${{ matrix.new-query-planner }}.lcov
+        coverage xml -o .\report-output\coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.daft-runner }}-${{ matrix.pyarrow-version }}-${{ matrix.new-query-planner }}.xml
+        # cargo llvm-cov --no-run --lcov --output-path report-output\rust-coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.daft-runner }}-${{ matrix.pyarrow-version }}-${{ matrix.new-query-planner }}.lcov
       env:
         DAFT_RUNNER: ${{ matrix.daft-runner }}
         DAFT_NEW_QUERY_PLANNER: ${{ matrix.new-query-planner }}