add binding for reccursive iter to python

Eventual-Inc · Sep 12, 2023 · 037a84f · 037a84f
1 parent 4f9be30
commit 037a84f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 12 deletions.
diff --git a/src/daft-core/src/array/ops/concat_agg.rs b/src/daft-core/src/array/ops/concat_agg.rs
@@ -165,7 +165,7 @@ mod test {
             Field::new("foo", DataType::List(Box::new(DataType::Int64))),
             Int64Array::from((
                 "item",
-                Box::new(arrow2::array::Int64Array::from_iter(vec![].iter())),
+                Box::new(arrow2::array::Int64Array::from_iter([].iter())),
             ))
             .into_series(),
             arrow2::offset::OffsetsBuffer::<i64>::try_from(vec![0, 0, 0, 0])?,
@@ -190,7 +190,7 @@ mod test {
             Int64Array::from((
                 "item",
                 Box::new(arrow2::array::Int64Array::from_iter(
-                    vec![Some(0), Some(1), Some(1), Some(2), None, None, Some(10000)].iter(),
+                    [Some(0), Some(1), Some(1), Some(2), None, None, Some(10000)].iter(),
                 )),
             ))
             .into_series(),
@@ -225,7 +225,7 @@ mod test {
             Int64Array::from((
                 "item",
                 Box::new(arrow2::array::Int64Array::from_iter(
-                    vec![
+                    [
                         Some(0),
                         Some(0),
                         Some(0),

diff --git a/src/daft-io/src/object_io.rs b/src/daft-io/src/object_io.rs
@@ -7,7 +7,6 @@ use futures::stream::{BoxStream, Stream};
 use futures::StreamExt;
 use tokio::sync::mpsc::Sender;
 use tokio::sync::OwnedSemaphorePermit;
-use tokio::sync::Semaphore;
 
 use crate::local::{collect_file, LocalFile};
 

diff --git a/src/daft-io/src/python.rs b/src/daft-io/src/python.rs
@@ -2,13 +2,9 @@ pub use common_io_config::python::{AzureConfig, GCSConfig, IOConfig};
 pub use py::register_modules;
 
 mod py {
-    use crate::{
-        get_io_client, get_runtime,
-        object_io::{recursive_iter, LSResult},
-        parse_url,
-    };
+    use crate::{get_io_client, get_runtime, object_io::recursive_iter, parse_url};
     use common_error::DaftResult;
-    use futures::{StreamExt, TryStreamExt};
+    use futures::TryStreamExt;
     use pyo3::{
         prelude::*,
         types::{PyDict, PyList},

diff --git a/src/daft-plan/src/test/mod.rs b/src/daft-plan/src/test/mod.rs
@@ -12,7 +12,7 @@ use crate::{
 pub fn dummy_scan_node(fields: Vec<Field>) -> LogicalPlanBuilder {
     let schema = Arc::new(Schema::new(fields).unwrap());
     LogicalPlanBuilder::table_scan(
-        FileInfos::new_internal(vec!["/foo".to_string()], vec![None], vec![None]).into(),
+        FileInfos::new_internal(vec!["/foo".to_string()], vec![None], vec![None]),
         schema,
         FileFormatConfig::Json(JsonSourceConfig {}).into(),
         StorageConfig::Native(NativeStorageConfig::new_internal(None).into()).into(),
@@ -24,7 +24,7 @@ pub fn dummy_scan_node(fields: Vec<Field>) -> LogicalPlanBuilder {
 pub fn dummy_scan_node_with_limit(fields: Vec<Field>, limit: Option<usize>) -> LogicalPlanBuilder {
     let schema = Arc::new(Schema::new(fields).unwrap());
     LogicalPlanBuilder::table_scan_with_limit(
-        FileInfos::new_internal(vec!["/foo".to_string()], vec![None], vec![None]).into(),
+        FileInfos::new_internal(vec!["/foo".to_string()], vec![None], vec![None]),
         schema,
         FileFormatConfig::Json(JsonSourceConfig {}).into(),
         StorageConfig::Native(NativeStorageConfig::new_internal(None).into()).into(),