[CHORE] Refactor logging #2257
Annotations
2 errors
|
Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"}
{
name: 'HttpError',
id: '6528264776',
status: 422,
response: {
url: 'https://api.github.com/repos/Eventual-Inc/Daft/releases/124512520',
status: 422,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-length': '195',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Mon, 16 Oct 2023 02:27:39 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'GitHub.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-github-permissions': 'contents=write',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-api-version-selected': '2022-11-28',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': '3C07:4BBD:254AE53:4CC237F:652C9F9B',
'x-ratelimit-limit': '1000',
'x-ratelimit-remaining': '953',
'x-ratelimit-reset': '1697425314',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '47',
'x-xss-protection': '0'
},
data: {
message: 'Validation Failed',
errors: [
{
resource: 'Release',
code: 'invalid',
field: 'target_commitish'
}
],
documentation_url: 'https://docs.github.com/rest/releases/releases#update-a-release'
}
},
request: {
method: 'PATCH',
url: 'https://api.github.com/repos/Eventual-Inc/Daft/releases/124512520',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'probot/12.2.5 octokit-core.js/3.5.1 Node.js/16.20.2 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"body":"## Changes\\n\\n## 🚀 Performance Improvements\\n\\n- [PERF] Use pyarrow table for pickling rather than ChunkedArray @samster25 (#1488)\\n- [PERF] Use region from system and leverage cached credentials when making new clients @samster25 (#1490)\\n- [PERF] Update default max\\\\_connections 64->8 because it is now per-io-thread @jaychia (#1485)\\n- [PERF] Pass-through multithreaded\\\\_io flag in read\\\\_parquet @jaychia (#1484)\\n\\n## 👾 Bug Fixes\\n\\n- [BUG] Fix local globbing of current directory @jaychia (#1494)\\n- [BUG] fix script to upload file 1 at a time @samster25 (#1492)\\n- [CHORE] Add tests and fixes for Azure globbing @jaychia (#1482)\\n\\n## 🧰 Maintenance\\n\\n- [CHORE] Add Workflow to build artifacts and upload to S3 @samster25 (#1491)\\n- [CHORE] Update default num\\\\_tries on S3Config to 25 @jaychia (#1487)\\n- [CHORE] Add tests and fixes for Azure globbing @jaychia (#1482)\\n","draft":true,"prerelease":false,"name":"v0.1.21","tag_name":"v0.1.21","target_commitish":"refs/pull/1489/merge"}',
request: {}
},
event: {
id: '6528264776',
name: 'pull_request',
payload: {
action: 'edited',
changes: {
body: {
from: '1. Removes `loguru` as a dependency\r\n' +
'2. Removes custom handler that forwards logs to loguru\r\n' +
'3. Removes all custom formatting of our logs\r\n' +
'4. Warning which runner is being used is only done now for when the PyRunner is being used with an existing Ray connection\r\n' +
'\r\n' +
'I did (3) because Daft is a library, and custom formatting of logs should be done by the application. E.g. if a user was building a webserver with their own custom logging setup, then Daft mangling log formatting on the root logg
|
|
HttpError: Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"}
at /home/runner/work/_actions/release-drafter/release-drafter/v5/dist/index.js:8462:21
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async Job.doExecute (/home/runner/work/_actions/release-drafter/release-drafter/v5/dist/index.js:30793:18)
{
name: 'AggregateError',
event: {
id: '6528264776',
name: 'pull_request',
payload: {
action: 'edited',
changes: {
body: {
from: '1. Removes `loguru` as a dependency\r\n' +
'2. Removes custom handler that forwards logs to loguru\r\n' +
'3. Removes all custom formatting of our logs\r\n' +
'4. Warning which runner is being used is only done now for when the PyRunner is being used with an existing Ray connection\r\n' +
'\r\n' +
'I did (3) because Daft is a library, and custom formatting of logs should be done by the application. E.g. if a user was building a webserver with their own custom logging setup, then Daft mangling log formatting on the root logger would be very annoying.\r\n' +
'\r\n' +
'This is what our logs look like now on a jupyter notebook:\r\n' +
'<img width="1074" alt="image" src="https://github.com/Eventual-Inc/Daft/assets/17691182/c5674a52-b41a-40c5-aebd-9a9ddc965915">\r\n' +
'\r\n' +
'Enabling more verbose logs at a higher level (e.g. INFO logs) is performed by the user/embedding that uses Daft, e.g.\r\n' +
'\r\n' +
'```\r\n' +
'import logging\r\n' +
'\r\n' +
'logging.basicConfig(\r\n' +
" format='%(asctime)s,%(msecs)03d %(levelname)-8s [%(pathname)s:%(lineno)d] %(message)s',\r\n" +
" datefmt='%Y-%m-%d:%H:%M:%S',\r\n" +
' level=logging.INFO,\r\n' +
')\r\n' +
'\r\n' +
'# Outputs logs that look like:\r\n' +
'# 2023-10-16:11:25:46,195 INFO [/Users/jaychia/.cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-config-0.55.3/src/meta/region.rs:43] load_region; provider=EnvironmentVariableRegionProvider { env: Env(Real) }\r\n' +
'```\r\n' +
'\r\n' +
'Daft now respects normal Python logging and does not rely on loguru at all to do any of this configurations. This lets us play much nicer with applications that use normal Python logging.\r\n'
}
},
number: 1489,
organization: {
avatar_url: 'https://avatars.githubusercontent.com/u/98941975?v=4',
description: 'Eventual Computing',
events_url: 'https://api.github.com/orgs/Eventual-Inc/events',
hooks_url: 'https://api.github.com/orgs/Eventual-Inc/hooks',
id: 98941975,
issues_url: 'https://api.github.com/orgs/Eventual-Inc/issues',
login: 'Eventual-Inc',
members_url: 'https://api.github.com/orgs/Eventual-Inc/members{/member}',
node_id: 'O_kgDOBeW8Fw',
public_members_url: 'https://api.github.com/orgs/Eventual-Inc/public_members{/member}',
repos_url: 'https://api.github.com/orgs/Eventual-Inc/repos',
url: 'https://api.github.com/orgs/Eventual-Inc'
},
pull_request: {
_links: {
comments: {
href: 'https://api.github.com/repos/Eventual-Inc/Daft/issues/1489/comments'
},
commits: {
href: 'https://api.github.com/repos/Eventual-Inc/Daft/pulls/1489/commits'
},
html: { href: 'https://github.com/Eventual-Inc/Daft/pull/1489' },
issue: {
href: 'https://api.github.com/repos/Eventual-Inc/Daft/issues/1489'
},
review_comment: {
href: 'https://api.github.com/repos/Eventual-Inc/Daft/pulls/comments{/number}'
},
review_comments: {
href: 'https://api.github.com/repos/Eventual-Inc/Daft/pulls/1489/comments'
},
self: {
href: 'https://ap
|
The logs for this run have expired and are no longer available.
Loading