Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle finish and error events to avoid dead _flush loop #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hellolwq
Copy link

samples.zip

sample zip files will cause unzip in dead _flush loop, handle the error and finish events can avoid this.

@ZJONSSON
Copy link

fyi, your sample file works with an active fork unzipper

const request = require('request');
const unzipper = require('unzipper');

request('https://github.com/EvanOxfeld/node-unzip/files/1678258/samples.zip')
  .pipe(unzipper.Parse())
  .on('entry', entry => entry.autodrain())
  .promise()
  .then( () => console.log('done'), e => console.log('error',e));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants