Add Damnit and Related Packages #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertRosca
force-pushed
the
feat/add-damnit
branch
from
1ed5e3a to
e9e5e37
Compare
|
To test on Maxwell: module load exfel mambaforge
conda activate amore-mid |
JamesWrigley
force-pushed
the
feat/add-damnit
branch
from
e9e5e37 to
527f07d
Compare
JamesWrigley
requested review from
tmichela
and removed request for
JamesWrigley
|
View preview here - https://European-XFEL.github.io/environments/pr/29 (build for 6536b4f) Preview removed on merge/PR close with 26f96aa |
|
@RobertRosca I took the liberty of rebasing and updating this branch in preparation for the DAMNIT API package. Namely:
If you think this is ok then I'll delete 8da9aee and f9bbee3 before merging. |
|
LGTM |
|
👍 sounds good! Go ahead and make the changes @JamesWrigley and feel free to merge after |
JamesWrigley
force-pushed
the
feat/add-damnit
branch
from
527f07d to
6536b4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds recipes for damnit and mpl-pan-zoom.
In damnit's
pyproject.tomlQScintilla is pinned to2.13("QScintilla==2.13"), I want to pin this to2.13.*instead, but that makespip checkfail as the version specified inpyproject.tomland installed do not match. There's a patch to fix this in thepyproject.tomlfile.This change should also be done on damnit directly, but the patch should remain so that it's possible to build other versions/branches which have not had the version change made yet.