feat: Create Pool With Liquidity #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, on_pool_register_with_funds_reply in router
…PLY_ID in factory,
…h_funds in factory
…stPoolCreationWithFunds
…unds, PENDING_POOL_WITH_LIQUIDITY_REQUESTS in factory state
SlayerAnsh
requested changes
Nov 6, 2024
| funds: vec![], | ||
| label: "escrow".to_string(), | ||
| }); | ||
| PENDING_DEPOSIT_TOKEN.save(deps.storage, token.clone().token, &token)?; |
There was a problem hiding this comment.
Should we update our escrow contract instatiate msg to receive funds during instantiate? Note - If we use this approach, it should be able to use both native and cw20 funds
There was a problem hiding this comment.
I thought about this but wasn't sure how to handle cw20 funds
There was a problem hiding this comment.
We can try Instantiate2, let discuss this and implement it in another PR
SlayerAnsh
requested changes
Nov 6, 2024
This reverts commit be88663.
…ty_request, FUNDS_INFO item in router, call ibc_execute_add_liquidity in pool_register_reply
SlayerAnsh
approved these changes
Nov 13, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Allows to create a pool with liquidity
Type of Change
Related Issue
[Link to related issue, if applicable]
Testing
Integration test using
cw-orchinfactory.rsChecklist
Screenshots (if applicable)
[Add screenshots here]
Additional Notes
Still a work in progress