-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Factory Transfer Voucher #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlayerAnsh
requested changes
Oct 3, 2024
… instead of with limit, validate amount and recipient address in execute_transfer_virtual_balance
…ddresses from execute_transfer_voucher_internal
SlayerAnsh
requested changes
Oct 14, 2024
…ansfer_virtual_balance function, added security check for ChainIbcExecuteMsg::Transfer
SlayerAnsh
reviewed
Oct 14, 2024
SlayerAnsh
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This adds the ability to transfer voucher from user to another.
Type of Change
Related Issue
[Link to related issue, if applicable]
Testing
Steps to test:
Checklist
Screenshots (if applicable)
[Add screenshots here]
Additional Notes
[Any additional information or context]