Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh#1463 fix wrong day display in widget #1469

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

lmamane
Copy link

@lmamane lmamane commented Oct 6, 2023

The bug ultimately came from the fact that:

  • convertAllDayLocalToUtc and convertAllDayUtcToLocal are not guaranteed to preserve any part of the value of their recycle argument
  • older implementation of convertAlldayUtcToLocal just happened to accidentally preserve recycle's timezone
  • newer implementation does not; note that convertAlldayLocalToUtc already didn't preserve recycle's timezone previously
  • the code in buildFromCursor assumed that recycle was preserved, in particular by passing it to populateDayInfo while the latter critically depends on recycle having the correct timezone

Lionel Mamane added 3 commits October 6, 2023 11:21
since it is set in all cases
when subsequent uses _do_ depend on (part of) the value thereof.
@Gitsaibot
Copy link
Contributor

Can you please rebase.

@jspricke
Copy link
Member

Thanks! This looks ok to me, but I did not test it.

@Gitsaibot Gitsaibot merged commit 97cd1bd into Etar-Group:master Oct 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants