Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh#1457 set default duration on switch to non-AllDay #1460

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

lmamane
Copy link

@lmamane lmamane commented Oct 2, 2023

fixes enhancement request (issue) #1457

@Gitsaibot
Copy link
Contributor

Gitsaibot commented Oct 7, 2023

Seems to work. When testing I noticed that it can happen that the appointment is created twice. But I don't think that these changes are responsible for that.

How to reproduce:

  1. click on an all day event in month view -> day view opens
  2. long click on the event until new event dialog appears
  3. click on the screen to cancel
  4. click on the all day event -> now the event is loaded without title and when you save you have created a second event instead of customizing the first one.

@jspricke
Copy link
Member

@Gitsaibot not sure I got all your steps right but I was not able to reproduce your steps in Etar 1.0.34. Can you reproduce without this patch?

This sounds fine to me otherwise.

@Gitsaibot
Copy link
Contributor

I only testeted with version 1.0.36 and there i can reproduce(with and without) it.

@Gitsaibot Gitsaibot merged commit a2cdaf7 into Etar-Group:master Oct 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants