fixup! MonthByWeekFragment: Don't init loader in certain cases #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aayush Gupta <[email protected]>
theimpulson
referenced
this pull request
Sep 21, 2023
The new androidx LoaderManager requires to be NonNull. Strip out the cases that currently returns null and add them as check before initializing the LoaderManager. Also switch to androidx methods to get the LoaderManager instance. Signed-off-by: Aayush Gupta <[email protected]>
Gitsaibot
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the parent commit as the permission check is reversed.
Test
Ensure events are visible.