Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to register custom item transformers. #4871

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from

Conversation

Golfing7
Copy link

@Golfing7 Golfing7 commented Mar 24, 2022

Information

This PR closes Nothing.

Details

Proposed feature:
A system to allow plugin developers to add custom item transformers to metadata on items. Would be useful for plugins seeking to add custom item templates that could be dynamic or have special data on the item.

Environments tested:

OS: Windows 10

Java version: 1.8.0_281

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • [ x ] CraftBukkit 1.8.8

Demonstration:

A demonstration isn't fully applicable to the situation as it's not something that immediately affects anything.

@mdcfe
Copy link
Member

mdcfe commented Mar 24, 2022

Thanks for your interest in contributing to EssentialsX!

As it stands, MetaItemStack has been long in need of a major overhaul which I've been working on in a private branch. Part of this rework would overlap with the functionality added in this PR, so I will need some time to consider whether it would make sense to merge this PR at this stage.

@pop4959 pop4959 added type: enhancement Features and feature requests. module: main Issues or PRs for the main Essentials module labels May 21, 2022
@Golfing7
Copy link
Author

It's been a while, just would like to see if this could still be merged as the rework to MetaItemStack appears to have not come yet. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants