add back "Powered by Esri" attribution for vectorBasemapLayer when using an item ID #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cases In Esri#135 we added `Util.setEsriAttribution` to add the "Powered by Esri" attribution, but after Esri Leaflet v3.0.10, calling `Util.setEsriAttribution` does not add "Powered by Esri" anymore. Esri Leaflet only adds "Powered by Esri" for dynamic attribution situations. So now for non-dynamic situations, we must add the string ourself.
gowin20
approved these changes
Dec 3, 2024
patrickarlt
approved these changes
Dec 6, 2024
|
This was released in v4.2.6: https://github.com/Esri/esri-leaflet-vector/releases/tag/v4.2.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #228
In #135 we added add call to
Util.setEsriAttribution()to add the "Powered by Esri" attribution, but after Esri Leaflet v3.0.10, callingUtil.setEsriAttributiondoes not add "Powered by Esri" anymore. Esri Leaflet only adds "Powered by Esri" for dynamic attribution situations now. So now for non-dynamic situations, we must add the string ourselves.After this gets released: Esri/esri-leaflet#1397 ... we could use that function so that we do not need to hardcode that string here. But for now I'm adding it since I want to get this in before waiting for an Esri Leaflet release.