Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated data manager to handle no internet connection #1065

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

ZackAllen
Copy link
Contributor

@ZackAllen ZackAllen commented Jul 26, 2022

Description

The old data manager checks AGOL to create a portal item when verifying if offline data is present. This makes offline samples unusable offline. This PR fixes that behavior, so offline data that is already present on disk will load without an internet connection.

Type of change

  • Bug fix

Platforms tested on:

  • WPF .NET 6

  • WPF Framework

  • WinUI

  • Xamarin.Forms Android

  • Xamarin.Forms iOS

  • Xamarin.Forms UWP

  • UWP

  • Xamarin.Android

  • Xamarin.iOS

Checklist

  • Runs and compiles on all active platforms
  • Legacy platforms still compile and run (if applicable)
  • Branch is up to date with the latest main/v.next
  • All merge conflicts have been resolved
  • Self-review of changes
  • There are no warnings related to changes
  • No unrelated changes have been made to any other code or project files
  • sample_sync.py runs without making changes
  • Codemaid and XAML styler extensions have been run on every changed file
  • Code is commented with correct formatting
  • All variable and method names are good and make sense
  • There is no leftover commented code
  • Screenshots are correct size and display in description tab

@ZackAllen ZackAllen merged commit 1381dd8 into main Jul 27, 2022
@ZackAllen ZackAllen deleted the zallen/offlineDataUpdate branch July 27, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants