Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sequencer #96

Merged
merged 9 commits into from
Dec 15, 2023
Merged

Update sequencer #96

merged 9 commits into from
Dec 15, 2023

Conversation

jbearer
Copy link
Member

@jbearer jbearer commented Dec 12, 2023

@jbearer jbearer requested review from sveitser and nomaxg December 12, 2023 16:20
@jbearer jbearer marked this pull request as ready for review December 12, 2023 17:43
@jbearer jbearer marked this pull request as draft December 12, 2023 17:44
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Merging #96 (df569fa) into integration (e09fad5) will increase coverage by 17.66%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##           integration      #96       +/-   ##
================================================
+ Coverage        45.80%   63.47%   +17.66%     
================================================
  Files              178       16      -162     
  Lines             7337     1525     -5812     
  Branches          1161        0     -1161     
================================================
- Hits              3361      968     -2393     
+ Misses            3850      507     -3343     
+ Partials           126       50       -76     
Flag Coverage Δ
cannon-go-tests 63.47% <ø> (ø)
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests ?
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 162 files with indirect coverage changes

@jbearer
Copy link
Member Author

jbearer commented Dec 12, 2023

The devnet-allocs failure (and related failures) seems to be a bug in Forge. Upstream encountered this same problem and reverted a foundry update yesterday. It's possible we just need to wait for the ci-builder to be updated with the downgraded version of foundry

jbearer and others added 2 commits December 12, 2023 19:04
* Build foundry from source
- Use nodejs 20 like nvmrc.
* dev shell: pin geth 1.13.4

This matches the current .gethrc version. Updating the geth version is a
bit inconvenient but instructions are included as comments.

---------

Co-authored-by: Jeb Bearer <[email protected]>
@jbearer jbearer marked this pull request as ready for review December 15, 2023 14:02
Copy link
Collaborator

@sveitser sveitser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbearer jbearer merged commit 92a0550 into integration Dec 15, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sequencer
3 participants