-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy OP Stack onto sequencer docker compose #76
Conversation
nomaxg
commented
Sep 20, 2023
- Introduces a new docker compose configuration that connects an instance of the OP espresso demo stack to an existing sequencer network.
- Added a check to ensure that the corrected L1 origin is in the correct timeframe. Without this check, there was a bug where the L2 would occasionally correct to an L1 origin too far in the future.
- Currently only works with a geth instance: espresso sequencer geth
Bumps [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) from 42.0.0 to 48.0.1. - [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases) - [Commits](sindresorhus/eslint-plugin-unicorn@v42.0.0...v48.0.1) --- updated-dependencies: - dependency-name: eslint-plugin-unicorn dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.5.0 to 20.6.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Fixes a bug where the host incorrectly informs the client that a custom chain config is in use. The client then attempts to read the chain config pre-image data. However, this pre-image data will not be available in on-chain contexts.
ven -> even
it's -> its
…sm#7283) Bumps ethereum/client-go from v1.13.0 to v1.13.1. --- updated-dependencies: - dependency-name: ethereum/client-go dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…4-fix_indexer_Fix_uri_util fix(indexer): Fix uri util
…ndabot/npm_and_yarn/types/node-20.6.1 build(deps-dev): bump @types/node from 20.5.0 to 20.6.1
…ndabot/npm_and_yarn/types/node-20.6.3 build(deps-dev): bump @types/node from 20.5.0 to 20.6.3
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 0.34.1 to 0.34.4. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v0.34.4/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [glob](https://github.com/isaacs/node-glob) from 10.3.3 to 10.3.5. - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](isaacs/node-glob@v10.3.3...v10.3.5) --- updated-dependencies: - dependency-name: glob dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…ndabot/npm_and_yarn/vitest-0.34.4 build(deps-dev): bump vitest from 0.34.1 to 0.34.4
…ndabot/npm_and_yarn/glob-10.3.5 build(deps-dev): bump glob from 10.3.3 to 10.3.5
op-node/rollup/derive/batches.go
Outdated
log.Warn("error reading next possible L1 origin", "err", err, "origin", nextL1Number) | ||
return BatchUndecided | ||
} | ||
nextL1BlockEligible := nextL1Block.Time <= cfg.BlockTime+l2SafeHead.Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be cleaner to encapsulate this logic in EspressoL1Origin
, so it just takes the next L1BlockRef
, not a bool
. Then there's no chance of bugs from different callers having a different idea of what "eligible" means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed this feels better
@@ -0,0 +1,54 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the other devnets we don't commit this generate file, only the template. I think we should git rm
this and add it to packages/contracts-bedrock/.gitignore
. Unless there's a specific reason to version control it
…oy-devnet-protocol-versions contracts-bedrock: internal devnet ProtocolVersions deployment
…ndabot/npm_and_yarn/envalid-8.0.0 build(deps): bump envalid from 7.3.1 to 8.0.0
…te-libp2p go: update libp2p to fix Go 1.21 build
…tion, misc gitignore cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Any idea what's going on with the CI failures?
Looks like some strange version issue. quic-go is incompatible with go 1.21 apparently? |
I think that this may be the culprit, I'll try pinning this to 1.20: 60fd40a#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R815 |
Hmm actually just calls go test under the hood, not sure what the issue is |
Here we go: ethereum-optimism#7333 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, approving, please just make sure the build is fixed before merging
Will Cory seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |