Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit fixes #409

Closed
wants to merge 25 commits into from
Closed

Audit fixes #409

wants to merge 25 commits into from

Conversation

Sneh1999
Copy link

@Sneh1999 Sneh1999 commented Dec 26, 2024 •
edited
Loading

#402

This PR tracks all the changes requested by the auditors

zacshowa and others added 24 commits December 19, 2024 15:30
@zacshowa
Fix some audit issues
dde2cb3 
This commit fixes 2 audit issues present in the celestia compatible
integration. Specifically, issues #6 and #7
@zacshowa
Fix typo in attestation file location
dc4a579
@Sneh1999
remove hard coded attestation file
6f85a7f
@Sneh1999
fix some code quality issues
3b7c8a6
@Sneh1999
add back quote file check
9475ef4
@Sneh1999
change variable name
d8ae78f
@Sneh1999
add error checking
b40d1e7
@Sneh1999
change error to warm
b6908d1
@Sneh1999
Merge branch 'celestia-integration' into audit-fixes
98a8400
@ImJeremyHe
Remove skip position mechanism
14225f4
@ImJeremyHe
Remove unwrap in espressocrypto
2aaf01d
@Sneh1999
some code cleanup
355513e
@Sneh1999
lint
dc476cc
@ImJeremyHe @Sneh1999
remove transmute
a6e3eb2
@ImJeremyHe @Sneh1999
Update go client
e1bd322 
(cherry picked from commit 53ab629)
(cherry picked from commit ce1456a)
@ImJeremyHe @Sneh1999
use FetchRawHeaderByHeight
9a70c13
@Sneh1999
fix ci
3b3826b
@ImJeremyHe
Update go client
ad04eb2 
(cherry picked from commit 53ab629)
@ImJeremyHe
Using fetch raw header api and not to marshal header
4d9f4b1 
This will increase performance

(cherry picked from commit 905ee28)
@ImJeremyHe
Remove unsafe in espressocrypto
166530d 
(cherry picked from commit df1848b)
@ImJeremyHe
Use latest dev node
8a78bce
@ImJeremyHe
Merge branch 'audit-fixes' of github.com:EspressoSystems/nitro-espres…
f24a3ac 
…so-integration into audit-fixes
@ImJeremyHe
Fix CI
c8698b0
@Sneh1999
change name of EspressoSwitchDelayThreshold
eb2ce39 
(cherry picked from commit d640762)
@Sneh1999 Sneh1999 changed the title Audit fix Audit fixes Dec 26, 2024
@Sneh1999 Sneh1999 closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe will be requested when the pull request is marked ready for review ImJeremyHe is a code owner

@alysiahuggins alysiahuggins Awaiting requested review from alysiahuggins alysiahuggins will be requested when the pull request is marked ready for review alysiahuggins is a code owner

@zacshowa zacshowa Awaiting requested review from zacshowa zacshowa will be requested when the pull request is marked ready for review zacshowa is a code owner

@sveitser sveitser Awaiting requested review from sveitser sveitser will be requested when the pull request is marked ready for review sveitser is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer will be requested when the pull request is marked ready for review jbearer is a code owner

Assignees
No one assigned
Labels
backport integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sneh1999 @zacshowa @ImJeremyHe