Sync develop branch with recent commits #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* forge install: automata-dcap-attestation v0.1.1 * Add automata attestation to Sequencer Inbox * Add automata verifier to the Sequencer Inbox * Update tests and contracts * add address to the end * make hardhat build work as well * make tests work * make tests work * attempt tests * add tests * add tests for EspressoTEEVerifier * add tests to SequencerInbox * revert 4844 chanegs * source .env * fix broken ci * fix test * Make espressoTEEVerifier non upgrdeable and use V3QuoteVerifier contract directly * address comments
* Update scripts to use EspressoTEEVerifier * Update scripts to use EspressoTEEVerifier * address comments * check for undefined config * address comments and fix typo
* Add additional verification to EspressoTEEVerifier * fix tests * fix tests * cleanup * revert broken tests * fix ci * fix ci * address comments * address comments * add code docs
ImJeremyHe
requested review from
alysiahuggins,
zacshowa,
Sneh1999 and
sveitser
as code owners
Sneh1999
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Thanks @ImJeremyHe 🎉 🎉 This looks good too but we should try to fix the build!
* Contracts cleanup * add comment
In openzeppelin v4.8, revert message changed and error InvalidSignatureV is deprecated
Sneh1999
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits are cherry-picked from
celestia-integrationbranch.Currently this file test/foundry/ExpressLaneBalance.t.sol can't be compiled, and no workarounds have been found. Based on the fact that this file is only for test, I skip it in CI and
yarn:build.Relevant issues:
ethereum/solidity#14179
ethereum/solidity#14878