Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove global state #19

Merged
merged 2 commits into from
Aug 27, 2024
Merged

remove global state #19

merged 2 commits into from
Aug 27, 2024

Conversation

ImJeremyHe
Copy link
Member

Remove the extra global state that we added for the continuity check of hotshot blocks

EspressoSystems/nitro-espresso-integration#210

Copy link
Collaborator

@sveitser sveitser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but why not revert the commit where we added it?

@ImJeremyHe
Copy link
Member Author

We don't have a clear commit that just modifies the global states.

@ImJeremyHe ImJeremyHe changed the title Jh/remove global state remove global state Aug 27, 2024
@ImJeremyHe ImJeremyHe merged commit d226e9d into develop Aug 27, 2024
7 of 13 checks passed
@ImJeremyHe ImJeremyHe deleted the jh/remove-global-state branch August 27, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants