-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy RollupCreator and document the process #13
Conversation
There seems to be something wrong with the etherscan verification. The logs show that everything is already verified successfully but on Etherscan the contracts are not verified. I manually verified a Do you by any chance have an idea why the verification from the deployment script looks like it's working but isn't. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great. Left some comments. If it's not straight-forward to fix the etherscan verification we can open a separate issue for it and manually run hardhat verify
if necessary.
Seems like they use a deprecated package to verify which might be causing the issue |
Closes #153
This PR:
This PR does not:
Key places to review:
Please also review this documentation in notion - thank you :)
You can test this PR by following the instructions in the
ReadMe.md
on how to deploy contracts.