Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy RollupCreator and document the process #13

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

Sneh1999
Copy link
Collaborator

@Sneh1999 Sneh1999 commented Jul 22, 2024

Closes #153

This PR:

  • Documents the process on how to deploy contracts in this repo using hardhat and foundry
  • Updated the deployment scripts to make it compatible with our contratcs

This PR does not:

Key places to review:

Please also review this documentation in notion - thank you :)

You can test this PR by following the instructions in the ReadMe.md on how to deploy contracts.

@Sneh1999 Sneh1999 closed this Jul 22, 2024
@Sneh1999 Sneh1999 reopened this Jul 22, 2024
@Sneh1999 Sneh1999 marked this pull request as draft July 22, 2024 23:33
scripts/deployment.ts Outdated Show resolved Hide resolved
@Sneh1999 Sneh1999 marked this pull request as ready for review July 23, 2024 20:32
@Sneh1999 Sneh1999 requested a review from sveitser July 23, 2024 20:32
@sveitser
Copy link
Collaborator

There seems to be something wrong with the etherscan verification. The logs show that everything is already verified successfully but on Etherscan the contracts are not verified.

I manually verified a RollupCreator contract I deployed by running npx hardhat verify --network sepolia 0xc4F30D50A7Fdf79Bd54D35261511f204770E6cba and after that it ended up being verified on etherscan.

Do you by any chance have an idea why the verification from the deployment script looks like it's working but isn't.

README.md Outdated Show resolved Hide resolved
scripts/deployment.ts Outdated Show resolved Hide resolved
@sveitser sveitser self-requested a review July 24, 2024 13:53
Copy link
Collaborator

@sveitser sveitser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. Left some comments. If it's not straight-forward to fix the etherscan verification we can open a separate issue for it and manually run hardhat verify if necessary.

@Sneh1999
Copy link
Collaborator Author

Overall looks great. Left some comments. If it's not straight-forward to fix the etherscan verification we can open a separate issue for it and manually run hardhat verify if necessary.

Seems like they use a deprecated package to verify which might be causing the issue

@Sneh1999 Sneh1999 merged commit 516a1e9 into develop Jul 25, 2024
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants