Merging last two commits of the celestia-integration branch (#35)

* add names (#33) (cherry picked from commit 998a437) * Add names to the deprecated functions to not break abi (#34) * Add names to the deprecated functions to not break abi * remove unwanted changes (cherry picked from commit 418efec)
EspressoSystems · Dec 9, 2024 · 35e3e4b · 35e3e4b
1 parent 100536b
commit 35e3e4b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 14 deletions.
diff --git a/src/bridge/SequencerInbox.sol b/src/bridge/SequencerInbox.sol
@@ -179,7 +179,10 @@ contract SequencerInbox is DelegateCallAware, GasRefundEnabled, ISequencerInbox
         Deprecated because we created another `initialize` function that accepts the `EspressoTEEVerifier` contract
         address as a parameter which is used by the `SequencerInbox` contract to verify the TEE attestation quote.
      */
-    function initialize(IBridge, ISequencerInbox.MaxTimeVariation calldata) external onlyDelegated {
+    function initialize(
+        IBridge bridge_,
+        ISequencerInbox.MaxTimeVariation calldata maxTimeVariation_
+    ) external onlyDelegated {
         revert Deprecated();
     }
 
@@ -335,10 +338,10 @@ contract SequencerInbox is DelegateCallAware, GasRefundEnabled, ISequencerInbox
 
     /// @dev Deprecated, kept for abi generation and will be removed in the future
     function addSequencerL2BatchFromOrigin(
-        uint256,
-        bytes calldata,
-        uint256,
-        IGasRefunder
+        uint256 sequencerNumber,
+        bytes calldata data,
+        uint256 afterDelayedMessagesRead,
+        IGasRefunder gasRefunder
     ) external pure {
         revert Deprecated();
     }
@@ -348,12 +351,12 @@ contract SequencerInbox is DelegateCallAware, GasRefundEnabled, ISequencerInbox
         to verify that the batch is posted by the batch poster running in TEE.
      */
     function addSequencerL2BatchFromOrigin(
-        uint256,
-        bytes calldata,
-        uint256,
+        uint256 sequenceNumber,
+        bytes calldata data,
+        uint256 afterDelayedMessagesRead,
         IGasRefunder gasRefunder,
-        uint256,
-        uint256
+        uint256 prevMessageCount,
+        uint256 newMessageCount
     ) external refundsGas(gasRefunder, IReader4844(address(0))) {
         revert Deprecated();
     }

diff --git a/src/rollup/BridgeCreator.sol b/src/rollup/BridgeCreator.sol
@@ -86,10 +86,10 @@ contract BridgeCreator is Ownable {
      * been posted by a batch poster running in the TEE.
      */
     function createBridge(
-        address,
-        address,
-        address,
-        ISequencerInbox.MaxTimeVariation calldata
+        address adminProxy,
+        address rollup,
+        address nativeToken,
+        ISequencerInbox.MaxTimeVariation calldata maxTimeVariation
     ) external returns (BridgeContracts memory) {
         revert Deprecated();
     }