Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] The Great Refactor #222

Closed
wants to merge 3 commits into from
Closed

[WIP] The Great Refactor #222

wants to merge 3 commits into from

Conversation

QuentinI
Copy link
Contributor

Closes #<ISSUE_NUMBER>

This PR:

This PR does not:

Key places to review:

@QuentinI QuentinI marked this pull request as draft October 30, 2024 20:44
@QuentinI QuentinI force-pushed the ag/refactor branch 2 times, most recently from e11a1a3 to 7f3e7c0 Compare October 31, 2024 04:01
@coveralls
Copy link

coveralls commented Oct 31, 2024

Pull Request Test Coverage Report for Build 11710478172

Details

  • 206 of 632 (32.59%) changed or added relevant lines in 10 files are covered.
  • 41 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-9.8%) to 63.892%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/legacy/src/service.rs 10 11 90.91%
crates/shared/src/utils.rs 0 3 0.0%
crates/marketplace/src/hooks.rs 0 10 0.0%
crates/shared/src/coordinator/builder_state_map.rs 154 165 93.33%
crates/marketplace/src/testing/integration.rs 0 17 0.0%
crates/shared/src/block.rs 13 30 43.33%
crates/shared/src/state.rs 18 100 18.0%
crates/marketplace/src/service.rs 0 132 0.0%
crates/shared/src/coordinator/mod.rs 0 153 0.0%
Files with Coverage Reduction New Missed Lines %
crates/marketplace/src/testing/integration.rs 1 0.0%
crates/shared/src/utils.rs 10 73.6%
crates/marketplace/src/service.rs 30 0.0%
Totals Coverage Status
Change from base Build 11708201498: -9.8%
Covered Lines: 1842
Relevant Lines: 2883

💛 - Coveralls

@QuentinI QuentinI force-pushed the ag/refactor branch 5 times, most recently from 32fc623 to 5d70fe3 Compare November 5, 2024 18:13
@QuentinI QuentinI changed the title [EARLY DRAFT] The Great Refactor [DRAFT] The Great Refactor Nov 5, 2024
@QuentinI QuentinI changed the title [DRAFT] The Great Refactor [WIP] The Great Refactor Nov 5, 2024
@QuentinI QuentinI force-pushed the ag/refactor branch 3 times, most recently from ecaaf0b to 9705123 Compare November 5, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants