Setting up tide-disco bindings #9
Conversation
| <<I as NodeType>::BlockPayload as BlockPayload>::Metadata, | ||
| ); | ||
| pub type BlockHash<I: NodeType> = Commitment<HashableBlock<I>>; | ||
| impl<I: NodeType> Default for HashableBlock<I> { |
There was a problem hiding this comment.
Why do we need default for this?
There was a problem hiding this comment.
The tide-disco type resolver needed it for extracting the parameter from TaggedBase64 for claim_block. I didn't really take the time to dig into why...
There was a problem hiding this comment.
That's odd. I don't see any Default requirement in https://github.com/EspressoSystems/tide-disco/blob/main/src/request.rs. Could you point me to where the requirement is coming from? I feel like this shouldn't be required (although it's not a big deal for now and does not have to block this PR)
There was a problem hiding this comment.
Looking at it again, I think it's because of the way I originally invoked .blob_param(), which I changed before the push...
... but this should be gone once I update with Artemii's changes to HotShot.
|
|
||
| #[derive(Clone, Debug, Snafu, Deserialize, Serialize)] | ||
| #[snafu(visibility(pub))] | ||
| pub enum BuildError { |
There was a problem hiding this comment.
Assuming we will change this to be more specific to the errors the builder can encounter, once we start implementing the traits?
| <<I as NodeType>::BlockPayload as BlockPayload>::Metadata, | ||
| ); | ||
| pub type BlockHash<I: NodeType> = Commitment<HashableBlock<I>>; | ||
| impl<I: NodeType> Default for HashableBlock<I> { |
There was a problem hiding this comment.
That's odd. I don't see any Default requirement in https://github.com/EspressoSystems/tide-disco/blob/main/src/request.rs. Could you point me to where the requirement is coming from? I feel like this shouldn't be required (although it's not a big deal for now and does not have to block this PR)
No description provided.