Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hotshot version 0.5.20 #37

Closed
wants to merge 4 commits into from
Closed

Conversation

move47
Copy link
Contributor

@move47 move47 commented Mar 1, 2024

No description provided.

@move47 move47 changed the title Hg/update hotshot version update hotshot version 0.5.20 Mar 1, 2024
@move47 move47 mentioned this pull request Mar 1, 2024
@move47 move47 closed this Mar 1, 2024
@move47
Copy link
Contributor Author

move47 commented Mar 1, 2024

updates are already in #38

Copy link
Contributor

@nyospe nyospe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, other than the serde line (which isn't good) and the version tag, this is the same as mine. I'm going to ask for this one to be discarded in favor of mine.

hotshot-types = { git = "https://github.com/EspressoSystems/HotShot.git", tag = "0.5.14" }
serde = { version = "1.0", features = ["derive"] }
hotshot-types = { git = "https://github.com/EspressoSystems/HotShot.git", tag = "0.5.20" }
serde = { version = "1.0.197", features = ["derive"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not like this. This is a dependabot thing, but it's bad. Just update the Cargo.lock instead.

In this case, you would do cargo update hotshot-types after making the change to Cargo.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants