add builder specific information #14
Conversation
|
|
| @@ -11,7 +11,8 @@ clap = { version = "4.4", features = ["derive", "env"] } | |||
| commit = { git = "https://github.com/EspressoSystems/commit.git" } | |||
| derive_more = "0.99" | |||
| futures = "0.3" | |||
| hotshot-types = { git = "https://github.com/EspressoSystems/HotShot.git", tag = "0.5.7.1" } | |||
| #hotshot-types = { git = "https://github.com/EspressoSystems/HotShot.git", tag = "0.5.7.1" } | |||
| hotshot-types = { git = "https://github.com/EspressoSystems/HotShot.git", branch = "main" } | |||
There was a problem hiding this comment.
Wasn't the plan to wait for new tag in HotShot before switching to BuilderCommitment?
cc: @nyospe
There was a problem hiding this comment.
Oh! I think you are right. I missed the conversation.
| @@ -11,7 +11,8 @@ clap = { version = "4.4", features = ["derive", "env"] } | |||
| commit = { git = "https://github.com/EspressoSystems/commit.git" } | |||
| derive_more = "0.99" | |||
| futures = "0.3" | |||
| hotshot-types = { git = "https://github.com/EspressoSystems/HotShot.git", tag = "0.5.7.1" } | |||
| #hotshot-types = { git = "https://github.com/EspressoSystems/HotShot.git", tag = "0.5.7.1" } | |||
| hotshot-types = { git = "https://github.com/EspressoSystems/HotShot.git", branch = "main" } | |||
There was a problem hiding this comment.
👍 , but we'll want to pin again once there's an appropriate tage on HotShot.
src/block_metadata.rs
Outdated
| pub block_size: u64, | ||
| pub offered_fee: u64, | ||
| pub signature: <<I as NodeType>::SignatureKey as SignatureKey>::PureAssembledSignatureType, | ||
| pub _phantom: PhantomData<I>, |
There was a problem hiding this comment.
Always put PhantomData last...
There was a problem hiding this comment.
Is it actually needed here and in Blockdata anyways? I is already used in other fields
There was a problem hiding this comment.
signature only binds SignatureKey::PureAssembledSignatureType, it cannot guarantee that there is a specific unique I: NodeType for that binding. Same for block_payload. We know it is whatever NodeType constrains BlockPayload to be, but we don't get the I bound to the struct.
We didn't need it when we had block_hash: BlockHash<I>, though...
|
Merged! |
It adds some extra information to api's response from the builder. Moreover, it also imports
BuilderCommitmentfromHotshot.